webex / webex-js-sdk

JavaScript SDK for Webex

https://webex.github.io/webex-js-sdk/

Other

167 stars 334 forks source link

fix(plugin-meetings): streamline rtxPackets and rtxBitrate #3662

Closed edvujic closed 1 week ago

edvujic commented 1 week ago

COMPLETES SPARK-535389

This pull request addresses

Incorrect reporting of rtxPackets and rtxBitrate for video MQEs in MQEIntervalSessionTransmitVideo and MQEIntervalSessionReceiveVideo.

by making the following changes

Updated the reporting of rtxPackets to use the WebRTC stat retransmittedPacketsReceived for received video and retransmittedPacketsSent for transmitted video.
Updated the reporting of rtxBitrate to use the WebRTC stat retransmittedBytesReceived for received video and retransmittedBytesSent for transmitted video.

Change Type

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation update
[ ] Tooling change
[ ] Internal code refactor

I certified that

[x] I have read and followed contributing guidelines
[x] I discussed changes with code owners prior to submitting this pull request
[x] I have not skipped any automated checks
[x] All existing and new tests passed
[ ] I have updated the documentation accordingly

aws-amplify-us-east-2[bot] commented 1 week ago

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3662.d3m3l2kee0btzx.amplifyapp.com