fix(plugin-meetings): trigger transcript connected after llm online

[mkesavan13]

COMPLETES AdHoc

This pull request addresses

So, while joining a meeting using the Web SDK, we check if the enableAutomaticLLM is set to true and connect the LLM websocket and once we do this, we notify the customer through an event meeting:transcription:connected

We do this once the updateLLMConnection method is resolved. However, this is inaccurate sometimes leading to early emission of the event

by making the following changes

To avoid such inaccuracy, this change will here-on listen to the 'online' event emitted by the LLM plugin and then trigger the meeting:transcription:connected event

Screenrecording

Here's link to the sharepoint upload.

Change Type

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [ ] Documentation update
• [ ] Tooling change
• [ ] Internal code refactor

The following scenarios where tested

• Wrote unit tests for the changes
• Updated the code and tested it by enabling Transcription from the sample app to see if the event is triggered
• Also tried to speak a few words to ensure we receive the transcription payload

I certified that

• [x] I have read and followed contributing guidelines
• [x] I discussed changes with code owners prior to submitting this pull request
• [x] I have not skipped any automated checks
• [x] All existing and new tests passed
• [x] I have updated the documentation accordingly

---

Make sure to have followed the contributing guidelines before submitting.

[aws-amplify-us-east-2[bot]]

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3668.d3m3l2kee0btzx.amplifyapp.com

[mkesavan13]

@sreenara

Have we found out when the resolution of this promise is inaccurate?

• It is only matter of time(speed) in which code gets executed. At the moment, as soon as the promise resolves, we trigger the SDK event to Instant Connect and Instant Connect starts the transcription
• Now, although the LLM is connected at that time, the parameter in the SDK would still say it is not connected and when they start transcription, we check if LLM is connected through this boolean and it says not connected at the times of lag.
• On the other hand, with this change, if we listen to the online event of llm and then trigger our event for Instant connect, we can be sure that LLM is connected already

Also, was there a design change on the LLM side that caused this issue?

• No, I believe. Just our issue of how we handled it earlier.

Third, is there an offline event analogous to the online event which we need to take care of? What if the LLM goes offline and we need to report this to the user and wait for online again? I see that we are switching off the listener in the function that's added.

• I think if the LLM goes offline and comes back online by itself, transcription will just continue to work.
• However, there is an offline event that we can make use of to notify user. Should we do that too?

[mkesavan13]

@Kesari3008 - Updated the PR description with recording share point link. Please check

[mkesavan13]

Oh. We cannot do that. So, we are just passing on this function to the llm.on as callback. However, if we do not have it as an arrow function, TriggerProxy would think we refer 'this' as LLM and not Meetings

For arrow functions, this always is where it is declared. Whereas for regular functions, it takes this as the object from where it is being called.

We cannot also bind it. If you see the test file, we test assert.calledWith(llm.on, 'online', meeting.handleLLMOnline)

If we bind it, llm.on would receive a bound function and not the actual meeting.handleLLMOnline

And if we do assert.calledWith(llm.on, 'online', meeting.handleLLMOnline.bind(meeting)) in the test, this would be considered as a separate bound function and not the same as it is bound in the meeting.

You can check processRelayEvent method as an example of this type of declarations in the same file

@sreenara