Removal of the non-blocking exports.getBuildType error that appears in the logs which was annoying
by making the following changes
As per this ticket, the exports was added to the getBuildType call so that it can be stubbed and tested in the unit tests. To address this, I've changed the getBuildType code to show a log that this method was called and then test webex.logger.log instead of getBuildType
The aim was to know if this method was called with the right attributes and that is accomplished
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation update
[ ] Tooling change
[x] Internal code refactor
The following scenarios were tested
I opened the sample app locally and tried joining a meeting and by this time, I already saw several logs for getBuildType being called and no errors that appeared earlier
COMPLETES SPARK-535057
This pull request addresses
Removal of the non-blocking
exports.getBuildType
error that appears in the logs which was annoyingby making the following changes
As per this ticket, the
exports
was added to thegetBuildType
call so that it can be stubbed and tested in the unit tests. To address this, I've changed the getBuildType code to show a log that this method was called and then testwebex.logger.log
instead ofgetBuildType
The aim was to know if this method was called with the right attributes and that is accomplished
Logs before and after
Change Type
The following scenarios were tested
I opened the sample app locally and tried joining a meeting and by this time, I already saw several logs for getBuildType being called and no errors that appeared earlier
I certified that
Make sure to have followed the contributing guidelines before submitting.