webex / webex-js-sdk

JavaScript SDK for Webex
https://webex.github.io/webex-js-sdk/
Other
167 stars 334 forks source link

fix(internal-plugin-metrics): remove exports.getBuildType error #3671

Closed mkesavan13 closed 2 days ago

mkesavan13 commented 4 days ago

COMPLETES SPARK-535057

This pull request addresses

Removal of the non-blocking exports.getBuildType error that appears in the logs which was annoying

by making the following changes

As per this ticket, the exports was added to the getBuildType call so that it can be stubbed and tested in the unit tests. To address this, I've changed the getBuildType code to show a log that this method was called and then test webex.logger.log instead of getBuildType

The aim was to know if this method was called with the right attributes and that is accomplished

Logs before and after

Before After
webex.github.io-1719717587011.log pr-3671.d3m3l2kee0btzx.amplifyapp.com-1719717796375.log

Change Type

The following scenarios were tested

I opened the sample app locally and tried joining a meeting and by this time, I already saw several logs for getBuildType being called and no errors that appeared earlier

I certified that


Make sure to have followed the contributing guidelines before submitting.

aws-amplify-us-east-2[bot] commented 4 days ago

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3671.d3m3l2kee0btzx.amplifyapp.com