webex / webex-js-sdk

JavaScript SDK for Webex
https://webex.github.io/webex-js-sdk/
Other
170 stars 336 forks source link

test(plugin-meetings): remove nested its #3684

Closed edvujic closed 5 days ago

edvujic commented 1 week ago

COMPLETES WEBEX-390386

This pull request addresses

We've encountered a problem within the unit tests for the stats analyzer where nested it statements are not executing as intended. Specifically, when an it block, which is meant to define a specific test case, is placed inside another it block, the inner it is being overlooked and not run.

The reason for this behavior is that the testing framework we are using is designed to support a flat structure of describe and it blocks.

by making the following changes

it('...', () => {
  it('...', () => {});
  it('...', () => {});
});

to

describe('...', () => {
  it('...', () => {});
  it('...', () => {});
});

Change Type

I certified that

aws-amplify-us-east-2[bot] commented 1 week ago

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3684.d3m3l2kee0btzx.amplifyapp.com

Shreyas281299 commented 1 week ago

@edvujic is statsAnalyser the only place where we were doing this? Or are there more plugins where this pattern was followed? I think we would find more places where this was followed.

@mkesavan13