search

webextension-toolbox / webpack-webextension-plugin

Webpack plugin that compiles WebExtension manifest.json files and adds smart auto reload
https://www.npmjs.com/package/@webextension-toolbox/webpack-webextension-plugin
Other
83 stars 21 forks source link

Bump the development-dependencies group across 1 directory with 8 updates #664

Closed dependabot[bot] closed 4 months ago

dependabot[bot] commented 5 months ago

Bumps the development-dependencies group with 8 updates in the / directory:

Package From To
@typescript-eslint/eslint-plugin 7.4.0 7.13.1
@typescript-eslint/parser 7.4.0 7.13.1
eslint 8.57.0 9.5.0
prettier 3.2.5 3.3.2
ts-jest 29.1.2 29.1.5
typescript 5.4.3 5.4.5
typescript-json-schema 0.63.0 0.64.0
webpack 5.91.0 5.92.1

Updates @typescript-eslint/eslint-plugin from 7.4.0 to 7.13.1

Release notes

Sourced from @​typescript-eslint/eslint-plugin's releases.

v7.13.1

7.13.1 (2024-06-17)

🩹 Fixes

  • eslint-plugin: [prefer-readonly] refine report locations (#8894)
  • eslint-plugin: [return-await] support explicit resource management (#9044)
  • eslint-plugin: [no-unsafe-member-access] differentiate a types-error any from a true any (#9291)

❤️ Thank You

You can read about our versioning strategy and releases on our website.

v7.13.0

7.13.0 (2024-06-10)

🚀 Features

  • eslint-plugin: [no-dynamic-delete] allow all string literals as index (#9280)
  • parser, typescript-estree: export withoutProjectParserOptions utility (#9233)
  • typescript-estree: require import = require() argument to be a string literal (#9226)
  • typescript-estree: forbid .body, .async, .generator on declare function (#9225)

🩹 Fixes

  • ast-spec: function-call-like callee should be Expression not LeftHandSideExpression (#9231)
  • eslint-plugin: [init-declarations] refine report locations (#8893)
  • eslint-plugin: [no-base-to-string] make error message more nuanced (#9281)
  • eslint-plugin: [no-unsafe-assignment] be more specific about error types (#8304)
  • eslint-plugin: [no-magic-numbers] fix implementation of the ignore option (#9167)
  • scope-manager: handle index signature in class (#9054)

❤️ Thank You

You can read about our versioning strategy and releases on our website.

v7.12.0

7.12.0 (2024-06-03)

... (truncated)

Changelog

Sourced from @​typescript-eslint/eslint-plugin's changelog.

7.13.1 (2024-06-17)

🩹 Fixes

  • eslint-plugin: [prefer-readonly] refine report locations

  • eslint-plugin: [return-await] support explicit resource management

  • eslint-plugin: [no-unsafe-member-access] differentiate a types-error any from a true any

❤️ Thank You

  • Kirk Waiblinger
  • Yukihiro Hasegawa

You can read about our versioning strategy and releases on our website.

7.13.0 (2024-06-10)

🚀 Features

  • typescript-estree: require import = require() argument to be a string literal

  • typescript-estree: forbid .body, .async, .generator on declare function

  • eslint-plugin: [no-dynamic-delete] allow all string literals as index

🩹 Fixes

  • ast-spec: function-call-like callee should be Expression not LeftHandSideExpression

  • scope-manager: handle index signature in class

  • eslint-plugin: [init-declarations] refine report locations

  • eslint-plugin: [no-base-to-string] make error message more nuanced

  • eslint-plugin: [no-unsafe-assignment] be more specific about error types

  • eslint-plugin: [no-magic-numbers] fix implementation of the ignore option

❤️ Thank You

  • Fotis Papadogeorgopoulos
  • Joshua Chen

... (truncated)

Commits
  • 1212a8f chore(release): publish 7.13.1
  • af34737 docs: improve return-await description about motivation (#9201)
  • bf48dc5 fix(eslint-plugin): [no-unsafe-member-access] differentiate a types-error any...
  • 33acc50 fix(eslint-plugin): [return-await] support explicit resource management (#9044)
  • 50ed604 fix(eslint-plugin): [prefer-readonly] refine report locations (#8894)
  • 8a178ed chore(release): publish 7.13.0
  • 63e53e2 chore(deps): update dependency prettier to v3.3.1 (#9308)
  • fb52f78 feat(eslint-plugin): [no-dynamic-delete] allow all string literals as index (...
  • ab2916c chore: enable eslint-plugin/no-property-in-node internally (#9261)
  • 629035f docs: mention rule scripts under Local Development (#9258)
  • Additional commits viewable in compare view


Updates @typescript-eslint/parser from 7.4.0 to 7.13.1

Release notes

Sourced from @​typescript-eslint/parser's releases.

v7.13.1

7.13.1 (2024-06-17)

🩹 Fixes

  • eslint-plugin: [prefer-readonly] refine report locations (#8894)
  • eslint-plugin: [return-await] support explicit resource management (#9044)
  • eslint-plugin: [no-unsafe-member-access] differentiate a types-error any from a true any (#9291)

❤️ Thank You

You can read about our versioning strategy and releases on our website.

v7.13.0

7.13.0 (2024-06-10)

🚀 Features

  • eslint-plugin: [no-dynamic-delete] allow all string literals as index (#9280)
  • parser, typescript-estree: export withoutProjectParserOptions utility (#9233)
  • typescript-estree: require import = require() argument to be a string literal (#9226)
  • typescript-estree: forbid .body, .async, .generator on declare function (#9225)

🩹 Fixes

  • ast-spec: function-call-like callee should be Expression not LeftHandSideExpression (#9231)
  • eslint-plugin: [init-declarations] refine report locations (#8893)
  • eslint-plugin: [no-base-to-string] make error message more nuanced (#9281)
  • eslint-plugin: [no-unsafe-assignment] be more specific about error types (#8304)
  • eslint-plugin: [no-magic-numbers] fix implementation of the ignore option (#9167)
  • scope-manager: handle index signature in class (#9054)

❤️ Thank You

You can read about our versioning strategy and releases on our website.

v7.12.0

7.12.0 (2024-06-03)

... (truncated)

Changelog

Sourced from @​typescript-eslint/parser's changelog.

7.13.1 (2024-06-17)

This was a version bump only for parser to align it with other projects, there were no code changes.

You can read about our versioning strategy and releases on our website.

7.13.0 (2024-06-10)

🚀 Features

  • parser, typescript-estree: export withoutProjectParserOptions utility

❤️ Thank You

  • Fotis Papadogeorgopoulos
  • Joshua Chen
  • Kirk Waiblinger
  • Tobiloba Adedeji
  • Vinccool96
  • YeonJuan

You can read about our versioning strategy and releases on our website.

7.12.0 (2024-06-03)

🩹 Fixes

  • types: correct typing ParserOptions

❤️ Thank You

  • Abraham Guo
  • Han Yeong-woo
  • Joshua Chen
  • Kim Sang Du
  • Kirk Waiblinger
  • YeonJuan

You can read about our versioning strategy and releases on our website.

7.11.0 (2024-05-27)

This was a version bump only for parser to align it with other projects, there were no code changes.

You can read about our versioning strategy and releases on our website.

... (truncated)

Commits
  • 1212a8f chore(release): publish 7.13.1
  • 8a178ed chore(release): publish 7.13.0
  • c9a6dd9 feat(parser, typescript-estree): export withoutProjectParserOptions utility (...
  • 7e93b28 chore(release): publish 7.12.0
  • 2bbf656 fix(types): correct typing ParserOptions (#9202)
  • e360541 chore(release): publish 7.11.0
  • c18226e chore(release): publish 7.10.0
  • 77fc366 chore(release): publish 7.9.0
  • f53fece chore: add knip (#8192)
  • ee677f6 chore(release): publish 7.8.0
  • Additional commits viewable in compare view


Updates eslint from 8.57.0 to 9.5.0

Release notes

Sourced from eslint's releases.

v9.5.0

Features

  • b2d256c feat: no-sparse-arrays report on "comma" instead of the whole array (#18579) (fisker Cheung)

Bug Fixes

  • 6880286 fix: treat * as a universal pattern (#18586) (Milos Djermanovic)
  • 7fbe211 fix: message template for all files ignored (#18564) (Milos Djermanovic)
  • 469cb36 fix: Don't lint the same file multiple times (#18552) (Milos Djermanovic)
  • 5cff638 fix: improve message for ignored files without a matching config (#18404) (Francesco Trotta)

Documentation

  • 455f7fd docs: add section about including .gitignore files (#18590) (Milos Djermanovic)
  • 721eafe docs: update info about universal files patterns (#18587) (Francesco Trotta)
  • 8127127 docs: Update README (GitHub Actions Bot)
  • 55c2a66 docs: Update README (GitHub Actions Bot)
  • eb76282 docs: Update README (GitHub Actions Bot)
  • ff6e96e docs: baseConfig and overrideConfig can be arrays (#18571) (Milos Djermanovic)
  • d2d83e0 docs: Add mention of eslint-transforms to v9 migration guide (#18566) (Nicholas C. Zakas)
  • 9ce6832 docs: add callout box for unintuitive behavior (#18567) (Ben McCann)
  • b8db99c docs: Add VS Code info to config migration guide (#18555) (Nicholas C. Zakas)
  • 518a35c docs: Mention config migrator (#18561) (Nicholas C. Zakas)
  • eb440fc docs: specifying files with arbitrary or no extension (#18539) (Francesco Trotta)
  • 38c159e docs: Provide example of reading package.json for plugins meta (#18530) (Nicholas C. Zakas)
  • d16a659 docs: add link to migration guide for --ext CLI option (#18537) (Milos Djermanovic)
  • 73408de docs: add link to configuration file docs before examples (#18535) (Milos Djermanovic)

Chores

  • f588160 chore: upgrade @​eslint/js@​9.5.0 (#18591) (Milos Djermanovic)
  • 5890841 chore: package.json update for @​eslint/js release (Jenkins)
  • e9f4ccd chore: remove unused eslint-disable directive (#18589) (Milos Djermanovic)
  • 4b23ffd refactor: Move JS parsing logic into JS language (#18448) (Nicholas C. Zakas)
  • 1495b93 chore: update WebdriverIO packages (#18558) (Christian Bromann)
  • cea7ede chore: add website donate link instead of opencollective (#18582) (Strek)
  • ec94880 chore: package.json update for eslint-config-eslint release (Jenkins)
  • 6912586 chore: extract formatting rules into separate config (#18560) (Milos Djermanovic)
  • 9738f7e ci: fix CLI flags for c8, raise thresholds (#18554) (Francesco Trotta)
  • c6de7bb chore: update dependency markdownlint-cli to ^0.41.0 (#18538) (renovate[bot])
  • 2c8fd34 ci: pin @​wdio/browser-runner v8.36.0 (#18540) (唯然)

v9.4.0

Features

  • 89a4a0a feat: ignore IIFE's in the no-loop-func rule (#17528) (Nitin Kumar)

Bug Fixes

  • f6534d1 fix: skip processor code blocks that match only universal patterns (#18507) (Milos Djermanovic)
  • 7226ebd fix: allow implicit undefined return in no-constructor-return (#18515) (Ali Rezvani)
  • 389744b fix: use @eslint/config-inspector@latest (#18483) (唯然)
  • 70118a5 fix: func-style false positive with arrow functions and super (#18473) (Milos Djermanovic)

Documentation

... (truncated)

Changelog

Sourced from eslint's changelog.

v9.5.0 - June 14, 2024

  • f588160 chore: upgrade @​eslint/js@​9.5.0 (#18591) (Milos Djermanovic)
  • 5890841 chore: package.json update for @​eslint/js release (Jenkins)
  • 455f7fd docs: add section about including .gitignore files (#18590) (Milos Djermanovic)
  • e9f4ccd chore: remove unused eslint-disable directive (#18589) (Milos Djermanovic)
  • 721eafe docs: update info about universal files patterns (#18587) (Francesco Trotta)
  • 4b23ffd refactor: Move JS parsing logic into JS language (#18448) (Nicholas C. Zakas)
  • 6880286 fix: treat * as a universal pattern (#18586) (Milos Djermanovic)
  • 8127127 docs: Update README (GitHub Actions Bot)
  • b2d256c feat: no-sparse-arrays report on "comma" instead of the whole array (#18579) (fisker Cheung)
  • 1495b93 chore: update WebdriverIO packages (#18558) (Christian Bromann)
  • cea7ede chore: add website donate link instead of opencollective (#18582) (Strek)
  • 55c2a66 docs: Update README (GitHub Actions Bot)
  • eb76282 docs: Update README (GitHub Actions Bot)
  • ff6e96e docs: baseConfig and overrideConfig can be arrays (#18571) (Milos Djermanovic)
  • 7fbe211 fix: message template for all files ignored (#18564) (Milos Djermanovic)
  • ec94880 chore: package.json update for eslint-config-eslint release (Jenkins)
  • d2d83e0 docs: Add mention of eslint-transforms to v9 migration guide (#18566) (Nicholas C. Zakas)
  • 6912586 chore: extract formatting rules into separate config (#18560) (Milos Djermanovic)
  • 9ce6832 docs: add callout box for unintuitive behavior (#18567) (Ben McCann)
  • b8db99c docs: Add VS Code info to config migration guide (#18555) (Nicholas C. Zakas)
  • 518a35c docs: Mention config migrator (#18561) (Nicholas C. Zakas)
  • 469cb36 fix: Don't lint the same file multiple times (#18552) (Milos Djermanovic)
  • 9738f7e ci: fix CLI flags for c8, raise thresholds (#18554) (Francesco Trotta)
  • eb440fc docs: specifying files with arbitrary or no extension (#18539) (Francesco Trotta)
  • 38c159e docs: Provide example of reading package.json for plugins meta (#18530) (Nicholas C. Zakas)
  • c6de7bb chore: update dependency markdownlint-cli to ^0.41.0 (#18538) (renovate[bot])
  • 5cff638 fix: improve message for ignored files without a matching config (#18404) (Francesco Trotta)
  • d16a659 docs: add link to migration guide for --ext CLI option (#18537) (Milos Djermanovic)
  • 73408de docs: add link to configuration file docs before examples (#18535) (Milos Djermanovic)
  • 2c8fd34 ci: pin @​wdio/browser-runner v8.36.0 (#18540) (唯然)

v9.4.0 - May 31, 2024

  • 010dd2e chore: upgrade to @eslint/js@9.4.0 (#18534) (Francesco Trotta)
  • 5e1b5dc chore: package.json update for @​eslint/js release (Jenkins)
  • d7ab6f5 docs: update theme when when prefers-color-scheme changes (#18510) (Nitin Kumar)
  • 594145f refactor: switch to @eslint/config-array (#18527) (Francesco Trotta)
  • 525fdff docs: fix components files (#18519) (Tanuj Kanti)
  • 89a4a0a feat: ignore IIFE's in the no-loop-func rule (#17528) (Nitin Kumar)
  • 80747d2 docs: refactor prefer-destructuring rule (#18472) (Tanuj Kanti)
  • f6534d1 fix: skip processor code blocks that match only universal patterns (#18507) (Milos Djermanovic)
  • 7226ebd fix: allow implicit undefined return in no-constructor-return (#18515) (Ali Rezvani)
  • f06e0b5 docs: clarify func-style (#18477) (Cameron Steffen)
  • 389744b fix: use @eslint/config-inspector@latest (#18483) (唯然)
  • 70118a5 fix: func-style false positive with arrow functions and super (#18473) (Milos Djermanovic)

v9.3.0 - May 17, 2024

... (truncated)

Commits


Updates prettier from 3.2.5 to 3.3.2

Release notes

Sourced from prettier's releases.

3.3.2

🔗 Changelog

3.3.1

🔗 Changelog

3.3.0

diff

🔗 Release note

Changelog

Sourced from prettier's changelog.

3.3.2

diff

Fix handlebars path expressions starts with @ (#16358 by @​Princeyadav05)

{{! Input }}
<div>{{@x.y.z}}</div>

{{! Prettier 3.3.1 }}
<div>{{@​x}}</div>


{{! Prettier 3.3.2 }}
<div>{{@​x.y.z}}</div>

3.3.1

diff

Preserve empty lines in front matter (#16347 by @​fisker)

<!-- Input -->
---
foo:
  - bar1

    

  • 

    bar2
    

    • 

  • 

    bar3
    

    • 





Markdown


<!-- Prettier 3.3.0 -->




foo:


    

  • bar1
    • 

  • bar2
    • 

  • bar3
    • 





Markdown


<!-- Prettier 3.3.1 -->
</tr></table>

... (truncated)

Commits


Updates ts-jest from 29.1.2 to 29.1.5

Release notes

Sourced from ts-jest's releases.

v29.1.5

Please refer to CHANGELOG.md for details.

v29.1.4

Please refer to CHANGELOG.md for details.

v29.1.3

Please refer to CHANGELOG.md for details.

Changelog

Sourced from ts-jest's changelog.

29.1.5 (2024-06-16)

Bug Fixes

29.1.4 (2024-05-28)

Bug Fixes

  • fix(transformer): allow transforming of .cts/.mts extensions. (b8f6eaa), closes #3996

Features

  • feat: make cli generate esm config based on type: "module" (81a5f64), closes #4210 #4012

29.1.3 (2024-05-21)

Bug Fixes

  • add @jest/transform as an optional peer dependency (0ba7f86)
  • bring back Node 14 support (eda56a7)

Performance Improvements

  • remove ts resolved module cache file (4c88da5)
Commits
  • a5f3c8a chore(release): 29.1.5
  • 78d61b3 build(deps): Update dependency eslint-plugin-jsdoc to ^48.2.12
  • 59026b4 build(deps-dev): bump braces in /examples/type-module
  • 32cc6bb build(deps): Update dependency eslint-plugin-jsdoc to ^48.2.11
  • 487172c build(deps): Update actions/checkout digest to 692973e
  • 5560334 build(deps-dev): bump braces from 3.0.2 to 3.0.3 in /examples/js-with-ts
  • 0d9e359 build(deps): bump braces from 3.0.2 to 3.0.3 in /website
  • 9803934 build(deps): Update dependency prettier to ^3.3.2
  • 543182a build(deps): Update dependency esbuild to ~0.21.5
  • b59777e build(deps): Update @​types packages to ^7.13.0
  • Additional commits viewable in compare view


Updates typescript from 5.4.3 to 5.4.5

Release notes

Sourced from typescript's releases.

TypeScript 5.4.5

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

TypeScript 5.4.4

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

Commits
  • 27bcd4c Update LKG
  • 9f33bf1 🤖 Pick PR #58098 (Fix constraints of nested homomorph...) into release-5.4 (#...
  • 71b2f84 Bump version to 5.4.5 and LKG
  • 892936f 🤖 Pick PR #58083 (Don't propagate partial union/inter...) into release-5.4 (#...
  • 38a7c05 release-5.4: Always set node-version for setup-node (#58117)
  • b754fc3 🤖 Pick PR #57778 (fix type import check for default-i...) into release-5.4 (#...
  • 8eb3367 Bump version to 5.4.4 and LKG
  • de9096b 🤖 Pick PR #57871 (Divide-and-conquer strategy for int...) into release-5.4 (#...
  • 06aae98 🤖 Pick PR #57973 (Compare package.json paths with cor...) into release-5.4 (#...
  • 6d8134e 🤖 Pick PR #57637 (Fixed a regression related to deter...) into release-5.4 (#...
  • Additional commits viewable in compare view


Updates typescript-json-schema from 0.63.0 to 0.64.0

Commits


Updates webpack from 5.91.0 to 5.92.1

Release notes

Sourced from webpack's releases.

v5.92.1

Bug Fixes

  • Doesn't crash with an error when the css experiment is enabled and contenthash is used

v5.92.0

Bug Fixes

  • Correct tidle range's comutation for module federation
  • Consider runtime for pure expression dependency update hash
  • Return value in the subtractRuntime function for runtime logic
  • Fixed failed to resolve promise when eager import a dynamic cjs
  • Avoid generation extra code for external modules when remapping is not required
  • The css/global type now handles the exports name
  • Avoid hashing for @keyframe and @property at-rules in css/global type
  • Fixed mangle with destructuring for JSON modules
  • The stats.hasWarnings() method now respects the ignoreWarnings option
  • Fixed ArrayQueue iterator
  • Correct behavior of __webpack_exports_info__.a.b.canMangle
  • Changed to the correct plugin name for the CommonJsChunkFormatPlugin plugin
  • Set the chunkLoading option to the import when environment is unknown and output is module
  • Fixed when runtimeChunk has no exports when module chunkFormat used
  • [CSS] Fixed parsing minimized CSS import
  • [CSS] URLs in CSS files now have correct public path
  • [CSS] The css module type should not allow parser to switch mode
  • [Types] Improved context module types

New Features

  • Added platform target properties to compiler
  • Improved multi compiler cache location and validating it
  • Support import attributes spec (with keyword)
  • Support node: prefix for Node.js core modules in runtime code
  • Support prefetch/preload for module chunk format
  • Support "..." in the importsFields option for resolver
  • Root module is less prone to be wrapped in IIFE
  • Export InitFragment class for plugins
  • Export compileBooleanMatcher util for plugins
  • Export InputFileSystem and OutputFileSystem types
  • [CSS] Support the esModule generator option for CSS modules
  • [CSS] Support CSS when chunk format is module
Commits
  • a82e0cd chore(release): 5.92.1
  • 0d07d65 fix: error with contenthash and css experiment
  • 8efac43 test: added
  • 10638c0 chore(deps-dev): bump eslint-plugin-n from 17.8.1 to 17.9.0
  • d0f7b65 chore(deps-dev): bump lint-staged from 15.2.5 to 15.2.7
  • 50bd02c chore(deps-dev): bump @​eslint/js from 9.4.0 to 9.5.0
  • 9e395cd chore(deps): bump acorn from 8.11.3 to 8.12.0
  • db7f83c chore(deps-dev): bump globals from 15.4.0 to 15.6.0
  • b7d2cbe chore(deps-dev): bump @​types/node from 20.14.2 to 20.14.5
  • 18dab63 chore(deps-dev): bump @​types/node from 20.14.2 to 20.14.5
  • Additional commits viewable in compare view


Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor versio... _Description has been truncated_
socket-security[bot] commented 5 months ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@typescript-eslint/eslint-plugin@7.13.1 Transitive: environment, filesystem +44 8.27 MB jameshenry
npm/@typescript-eslint/parser@7.13.1 Transitive: environment, filesystem +38 3.48 MB jameshenry
npm/eslint@9.5.0 environment Transitive: filesystem, shell, unsafe +83 8.37 MB eslintbot
npm/prettier@3.3.2 environment, filesystem, unsafe 0 8.25 MB prettier-bot
npm/ts-jest@29.1.5 environment, filesystem, unsafe Transitive: eval, network, shell +156 16.5 MB kul
npm/typescript-json-schema@0.64.0 Transitive: environment, filesystem, unsafe +49 46.8 MB
npm/typescript@5.4.5 None 0 32.4 MB typescript-bot
npm/webpack@5.92.1 Transitive: environment, eval, filesystem, shell, unsafe +69 10.6 MB

🚮 Removed packages: npm/@typescript-eslint/eslint-plugin@7.4.0, npm/@typescript-eslint/parser@7.4.0, npm/eslint@8.57.0, npm/prettier@3.2.5, npm/ts-jest@29.1.2, npm/typescript-json-schema@0.63.0, npm/typescript@5.4.3, npm/webpack@5.91.0

View full report↗︎

dependabot[bot] commented 4 months ago

Superseded by #665.