webfactory / WebfactoryPolyglotBundle

Symfony bundle simplifying translations in Doctrine.
MIT License
3 stars 2 forks source link

Add integration test for Symfony #43

Closed mpdude closed 4 months ago

mpdude commented 4 months ago

20 declared compatibility with Symfony components at ^7.0. However, this probably never worked because the auto-wiring of PolyglotListener requires the annotation_reader, which is no longer present in symfony/framework-bundle 7.0.0.

So, add simple integration tests that make sure we actually test the code from src/DependencyInjection, and make sure those tests show the annotation_reader to be missing.

Extra check: We should probably declare symfony/framework-bundle as a dependency, too.

mpdude commented 4 months ago

Probably such tests would have caught what lead to #51