Add PHPStan and and make the code comply with the most strict level.
I noticed a few @psalm-internal annotations and I am unsure how to run the Psalm and I think it is not enforced and maintained anymore. There is TranslationInterface of generic type TTranslatedValue but non of its implementation is generic.
In this pull request, I propose to use PHPStan. There may be few quirky behaviours (mostly replacement of empty function and places where ShouldNotHappen is thrown) so please review them carefully.
Do any of the properties of TranslatableClassMetadata needs to be nullable? When i was researching usage of $translationsCollectionProperty I found out it does not need to be nullable at all. Am i missing something here?
Add PHPStan and and make the code comply with the most strict level.
I noticed a few
@psalm-internalannotations and I am unsure how to run the Psalm and I think it is not enforced and maintained anymore. There isTranslationInterfaceof generic typeTTranslatedValuebut non of its implementation is generic.In this pull request, I propose to use PHPStan. There may be few quirky behaviours (mostly replacement of empty function and places where
ShouldNotHappenis thrown) so please review them carefully.Do any of the properties of
TranslatableClassMetadataneeds to be nullable? When i was researching usage of$translationsCollectionPropertyI found out it does not need to be nullable at all. Am i missing something here?