Noscript element and more parameters

webfactory / piwik-bundle

Symfony Bundle with twig-function for the Matomo (fka Piwik) tracking code

MIT License

39 stars 16 forks source link

Noscript element and more parameters #17

Closed relthyg closed 5 years ago

relthyg commented 5 years ago

Adds the <noscript>-element and the parameters "setDoNotTrack", true, "trackPageView" and "enableLinkTracking" to the tracking code.

coveralls commented 5 years ago

Coverage remained the same at 100.0% when pulling 9979821d61ae2fb739cf570086aa7eaa80ca62ab on noscript-element_and_more_parameters into 1cbab8e45b362de3c053ede90badd2de0f36bf5e on 2.4.x.

mpdude commented 5 years ago

I'd be fine with this, even if it is (from a strict point of view) a possibly behaviour-changing commit.

Do you think you could fix the Travis tests as well?

relthyg commented 5 years ago

Sure. Do you agree that there is no need to support PHP 5.3 anymore?

mpdude commented 5 years ago

Sure, I think you can also drop HHVM.

mpdude commented 5 years ago

~Oh, wait. https://symfony.com/blog/symfony-4-end-of-hhvm-support~

~Let's keep HHVM on the branch for Symfony 2.x and drop it on the Symfony 3.x branch.~

Drop it. No need to spend time fixing stuff on a "legacy" branch that we're going to remove anyway.

TomaszGasior commented 5 years ago

Will be this PR ported into 2.5 version?

relthyg commented 5 years ago

Meanwhile, it is.