search

webfactory / piwik-bundle

Symfony Bundle with twig-function for the Matomo (fka Piwik) tracking code
MIT License
39 stars 16 forks source link

Fix CI Jobs #35

Closed MalteWunsch closed 2 years ago

MalteWunsch commented 3 years ago

Updated to our default Ci Workflow configuration. This skips runs for PHP 7.3 and 7.4, but for the moment, a working run of 7.2 seems to be better than failing runs for 7.2 - 7.4.

Removed lint.yml (it did no linting, just ran php-cs-fixer - which was already done in fix-cs-php.yml).

MalteWunsch commented 3 years ago

@mpdude Need help with running PHP 7.3, 7.4 and "Error: The ssh-private-key argument is empty. Maybe the secret has not been configured, or you are using a wrong secret name in your workflow file." in https://github.com/webfactory/piwik-bundle/pull/35/checks?check_run_id=3252238924

mpdude commented 2 years ago

Everything seemed to work fine in #39, so shall we ignore/close this?