Added compatibility with Doctrine DBAL 3.0

webfactory / slimdump

A tool for creating configurable dumps of large MySQL-databases.

MIT License

184 stars 26 forks source link

Added compatibility with Doctrine DBAL 3.0 #83

Closed Toflar closed 2 years ago

Toflar commented 3 years ago

See my own review for annotations :)

sebastiankugler commented 3 years ago

@Toflar Thank you for working on this and for your detailed explanations! I have created an internal task for this (Case 134127) and we will look at the PR soon.

mpdude commented 3 years ago

Danke Yanick for your time!

We keep the composer.lock file in this repo to make sure the .phar builds are reproducible. Could you update that as well to meet the new dependency requirements?

Toflar commented 3 years ago

Gerne Matthias :) I've updated the PR accordingly.

mpdude commented 3 years ago

I know it's a shame to ask, but do you really need to bump PHP requirements?

PHP 7.2 is the default PHP version in Ubuntu Bionic, a still-supported LTS version...

Toflar commented 3 years ago

Doctrine DBAL 3.1.x requires ^7.3 so I think if you want to remain up to speed, it's now time to ditch 7.2 :/

Toflar commented 2 years ago

Closing this as I have no intent to continue the work. Settled for my own dumper eventually which wasn't actually hard to implement :) Feel free to use the code if you want to upgrade the tool at some point though! Thanks for all the feedback :)