webfactory / slimdump

A tool for creating configurable dumps of large MySQL-databases.
MIT License
184 stars 26 forks source link

Remove `DumperTest` #90

Closed mpdude closed 2 years ago

mpdude commented 2 years ago

The DumperTest class is FUBAR in its design: It mocks the DBAL connection, making assumptions about the order and semantics of the queries the Dumper class will issue.

As long as we need to query the database for schema information and/or use the DBAL schema tool that does it, probably the only way to go for code like this is to do real functional/integration tests against a real database.

Since this broken test is getting in our way in #88, let's remove it.