search

webflo / drupal-core-strict

27 stars 7 forks source link

Create a PHP 7 Version of the package #7

Open jibran opened 6 years ago

jibran commented 6 years ago

On PHP7 core recommands to run following command to update PHPUnit.

composer update phpunit/phpunit phpspec/prophecy symfony/yaml --with-dependencies

As you can see symfony/yaml is a non dev package so it's updating some non-dev packages along the way. The 8.6.3 locks symfony/yaml package to v3.4.18 as per https://dispatcher.drupalci.org/job/php-7.2-apache_mysql5.5/2291/consoleFull whereas drupal-core-strict locks it to v3.4.15.

Because of this conflict, it is impossible to use drupal-core-strict with >=PHP7 so I suggest creating PHP 7 version on the release. Maybe a new package drupal-core-strict-php7. Thoughts?

jibran commented 5 years ago

This is still an issue with 8.6.7 on PHP 7.2

 Problem 1
    - Conclusion: remove webflo/drupal-core-strict 8.6.7
    - Conclusion: don't install webflo/drupal-core-strict 8.6.7
    - Installation request for webflo/drupal-core-strict (locked at 8.6.7, required as ^8.6) -> satisfiable by webflo/drupal-core-strict[8.6.7].
    - Conclusion: don't install symfony/polyfill-ctype v1.10.0
    - webflo/drupal-core-strict 8.6.7 requires symfony/polyfill-ctype v1.9.0 -> satisfiable by symfony/polyfill-ctype[v1.9.0].
    - Can only install one of: symfony/polyfill-ctype[v1.9.0, v1.10.0].
    - Can only install one of: symfony/polyfill-ctype[v1.10.0, v1.9.0].
    - Installation request for symfony/polyfill-ctype (locked at v1.10.0) -> satisfiable by symfony/polyfill-ctype[v1.10.0].
davereid commented 5 years ago

I would also like to support updating to PHPUnit 6 on our site and right now using this we're locked to version 4.