search

webflow / js-webflow-api

Node.js SDK for the Webflow Data API
https://www.npmjs.com/package/webflow-api
296 stars 95 forks source link

add TypeScript type definitions #27

Closed JCMais closed 3 years ago

JCMais commented 4 years ago

This should greatly improve the developer experience.

2020-09-28_11-29-43

There are a few TODOs in there, but nothing major.

Closes https://github.com/webflow/js-webflow-api/issues/20

jlambright commented 3 years ago

Is this even being considered?

Jeandcc commented 3 years ago

Come on guys.... @sansmischevia or @n-johnson , can you guys merge this?

namuol commented 3 years ago

@JCMais Thank you so much for this enhancement! I'm going to merge this PR as-is, but we may need to spend a little time reviewing the code before we publish to NPM. I'll be sure to follow up here once this has been published, hopefully within the next 24h.

Also thanks to everyone who has patiently waited for us to follow up here. Better late than never! 😅

namuol commented 3 years ago

Update: Version 0.5.4 is now live on NPM. You should be able to update your package to get TypeScript coverage now. Thank you for your patience!

Jeandcc commented 3 years ago

Awesome stuff! Should we expect more movement on this SDK moving forward?

JCMais commented 3 years ago

Thanks for getting this merged @namuol

mehdi-loup commented 2 years ago

@namuol not sure if that's intentional but the types are not included in the package. Might want to add them here

5amhoward commented 2 years ago

I was just about to add the types and create a PR, but I noticed that they were already in the repo. Thanks @JCMais and @namuol. Seems that the types are still missing from NPM, I guess this is the reason as @mehdi-loup suggested?