Web storage docs - Githubissues

gosteenBASIS commented 2 months ago

Web storage docs page completed to the best of my knowledge, with a couple caveats:

Not sure where it should go in the project structure. Currently placed under "Architecture."
Have not actually tested the sample code, although it appears correct based on the Javadocs
Note about the default 30-day expiration of the CookieStorage is based on comments in the code; have not verified otherwise.
According to the Javadocs, it looks like you can pass attributes to the constructors for SessionStorage and LocalStorage, but based on some brief research it doesn't look like they can actually take attributes like cookies do. I have omitted any mention of attributes in the sample code and description for those sections.

MatthewHawkins commented 2 months ago

Hey @gosteenBASIS, thanks for finishing this up, looks good!

I asked Hyyan where he would like the article to be put within the hierarchy, and will do that once he answers before I ask for his review
I tested and ran into a small issue that I'm hammering out with Hyyan. We can talk about testing code for the next few articles at some point next week

Thanks again, and once Hyyan and I tie up things, we'll get this merged!

sonarcloud[bot] commented 2 months ago

Quality Gate passed

hyyan commented 2 months ago

@gosteenBASIS Looks Good. Thank you!