search

webforj / webforj-docs

Documentation and code examples for webforJ.
https://docs.webforj.com
0 stars 2 forks source link

Spinner and Loading/BusyIndicator Docs #264

Closed laurenic0l closed 1 month ago

laurenic0l commented 2 months ago

First draft of Spinner and Loading/BusyIndicator docs

hyyan commented 1 month ago

/rebase

hyyan commented 1 month ago

@laurenic0l, please update the demo URLs to point to the correct programs.

hyyan commented 1 month ago

@laurenic0l check https://github.com/webforj/webforj-docs/pull/248 and update the documentation accordingly.

hyyan commented 1 month ago

@laurenic0l, don't nest the articles under the spinner group.

laurenic0l commented 1 month ago

Applied changes requested.

@hyyan this is ready for review again.

hyyan commented 1 month ago

@laurenic0l Looks good. I've requested a few minor changes. @MatthewHawkins, please give it a final review to ensure I didn't miss anything.

laurenic0l commented 1 month ago

@hyyan applied changes. @MatthewHawkins, please let me know if there's anything else I need to change.

MatthewHawkins commented 1 month ago

@hyyan I reviewed the articles with the demos, looks good on my end.

hyyan commented 1 month ago

@laurenic0l Looks great! It will be merged together with the demos PR soon.

hyyan commented 1 month ago

@laurenic0l, could you please review the unused CSS and remove it? Thanks!

hyyan commented 1 month ago

@laurenic0l could you please also link the new docs in the components gallery.

laurenic0l commented 1 month ago

@hyyan the unnecessary css has been removed and new docs have been linked in the components gallery.