search

webfox / laravel-xero-oauth2

A Laravel integration for Xero using the Oauth 2.0 spec
MIT License
50 stars 32 forks source link

PHP8 support? #44

Closed ok200paul closed 3 years ago

ok200paul commented 3 years ago

Is your feature request related to a problem? Please describe. The composer.json file has the restriction set for ^7.3 environments

Describe the solution you'd like Support for PHP8 environments

Describe alternatives you've considered

Additional context This is one of the few packages left in our application that is restricting us from moving up to PHP8. I've cloned the package and taken a look through the code, and from a 30-minute look (no testing), my IDE (PHPStorm set to PHP8 syntax) doesn't bark about any syntax issues. I'll see about popping a PR that covers this, some time this week - hopefully it helps!

hailwood commented 3 years ago

Hi @ok200paul,

We don't yet have any PHP8 projects, but I believe we're not using any features that would be deprecated in PHP8 so I've gone ahead and done a release (2.0.4) with the composer requirements updated.

Please comment back here if you run into any issues.

Cheers!

ok200paul commented 3 years ago

Thanks so much @hailwood - appreciate it! I'll keep a close eye.