Closed AbrahamBrookes closed 2 years ago
Hi @AbrahamBrookes,
You're right this is definitely a bug, It was introduced in #71 by us not updating this so it is a permanent API change.
Rather than setting the ID from the first tenant, can you please remove the tenant_id
property and add a tenants
property that expects the array?
Cheers!
cool thanks! that's been updated in 334b2c3 and tested working in my project:
Thanks @AbrahamBrookes,
That's now been released
Legend! Aw, my first PR package pull. This calls for a celebration 🥃
Congrats @AbrahamBrookes,
It's a good feeling!
When I was connecting my app using this library I hit an issue where the oauth credentials were throwing an error:
Undefined array key "tenant_id"
, because the structure from$oauth->getData()
had my tenants as an array, as opposed to the single tenant_id expected:I'm not sure if this is a permanent API change or if the response changes depending on your Xero account settings or what, but this change allows for my integration to proceed without breaking anything else, so I thought I might as well push it!