webfox / laravel-xero-oauth2

A Laravel integration for Xero using the Oauth 2.0 spec
MIT License
50 stars 32 forks source link

Lets add some tests #97

Closed JamesFreeman closed 3 months ago

JamesFreeman commented 3 months ago

Awaiting Merge

Todo

Root

Config

Routes

Events

Oauth2CredentialManagers

JamesFreeman commented 3 months ago

Hey, @hailwood,

Would you be able to have a review of this pr, I've had to make some changes to the core package to get the tests to work - just wanted to make sure you're happy with some of my changes.

JamesFreeman commented 3 months ago

It's also worth noting I've decided to go with PHPUnit for now, but happy to migrate to pest if you need me to.

hailwood commented 3 months ago

Thanks @JamesFreeman, I'll review this in the coming week. Apologies I'm a bit delayed on all your excellent contributions.

JamesFreeman commented 3 months ago

I've pulled in develop to this branch, for some reason the tests aren't running - I'm not sure if you have to permit me to run them against the repo.

hailwood commented 3 months ago

Hey @JamesFreeman, I'm wondering if it didn't run due to the conflicts? There should be an option here for me to approve the workflow run but I don't see it at all.

Could you please fix the conflicts and we'll try again?