search

webgio / Rotativa

Rotativa, /rota'tiva/. Make Pdf from Asp.Net MVC. Available on Nuget https://www.nuget.org/packages/Rotativa
http://letsfollowtheyellowbrickroad.blogspot.it/search/label/Rotativa
MIT License
622 stars 221 forks source link

Update to wkhtmltopdf version 0.12.6 #218

Open JoopStringer opened 4 years ago

JoopStringer commented 4 years ago

Hi Gio,

Any idea if you're going to update rotativa to support wkhtmltopdf 0.12.6, which was released on June 11, 2020 ? It supports JS/jQuery etc !

Would be nice !

Joop

webgio commented 4 years ago

Hi Joop, Hey didn't know that... Certenly going to do it, not sure I'll have time before going on vacation, though. Ciao, Giorgio

Il mer 24 giu 2020, 21:32 Joop Stringer notifications@github.com ha scritto:

Hi Gio,

Any idea if you're going to update rotativa to support wkhtmltopdf 0.12.6, which was released on June 11, 2020 ? It supports JS/jQuery etc !

Would be nice !

Joop

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/webgio/Rotativa/issues/218, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKCTPNOGITUMR73UD3XRRDRYJIFDANCNFSM4OHEOEEA .

JoopStringer commented 4 years ago

I just replaced the old wkhtmltopdf with the new and it works ... only need to change the special character replacement function you have. It now replace all chars above ASCII 127 ... and it should not !

mebymyself commented 3 years ago

@webgio would you be able to give this issue a high priority? 2 days ago wkhtmltopdf 0.12.5 suddenly stopped working for me on prod server ( not sure what caused it, might be widows got patched or something like that) Replaced the executable with new version and everything worked.

webgio commented 3 years ago

@mebymyself my problem with this is that changing wkhtmltopdf could break someone's PDF. Maybe a nice solution would be to just make switching version easy as changing/adding a config setting. Would you be interested to try to make a PR for this? Maybe we could include 2 or 3 different versions of wkhtmltopdf, set one as default but enable switching by adding a config settings. What do you think? Would really appreciate it!