search

webgme / webgme-taxonomy

A design studio for creating taxonomies which can then be used to tag various resources.
MIT License
0 stars 1 forks source link

Do multiple instances of storage adapters share locks? #520

Closed brollb closed 5 months ago

brollb commented 6 months ago

Looking through the code, it appears that locks (for repositories, etc) aren't actually shared across instances of the adapter - which is a bit problematic.

We should write some tests to confirm this is a problem and fix it.

yogeshVU commented 5 months ago

How are locks used in the storage adapters?

pmeijer commented 5 months ago

@yogeshVU The "locks" are essentially queues (typically associated with a repository or a content type) of calls where earlier ones are ensured to have finished before another call starts. You need to make sure you do all work within a queued call as the "lock" is released when the calls resolves (not a limitation but important to keep in mind).

Currently this locking mechanism only works within one webgme-server.

yogeshVU commented 5 months ago

Thanks. I was wondering what functionality do the locks serve in the storage adaptor.