webgme / webgme-taxonomy

A design studio for creating taxonomies which can then be used to tag various resources.
MIT License
0 stars 1 forks source link

Embed Tag Creator #554

Closed romancow closed 2 months ago

romancow commented 2 months ago

This embeds the "schema form" into the "Append Artifact Dialog", instead of forcing one to go to a separate page and upload a tags file. The dialog is now 2-steps -- a tag form, followed by setting the name and selecting upload files.

It also replaces the display in an artifact's "view metadata" dialog with a readonly version of the schema form.

Screen Shot 2024-06-14 at 12 44 10 PM

Screen Shot 2024-06-14 at 12 44 26 PM

Screen Shot 2024-06-14 at 12 44 45 PM

romancow commented 2 months ago

@pmeijer

  1. Yes, forgot about that. Didn't realize it was using a different one. 🤦
  2. I'll look into it.
  3. Yeah, I think I forgot a step here altogether. Looks like it isn't even setting the tags value i.nside the AppendArtifactDialog. 🤦

Also, looks like I broke a test that was relying on the dialog to look a certain way.

romancow commented 2 months ago

Ok @pmeijer, I think I've addressed your issues. Please take another look when you get a chance.

Also, fixed some style related issues and added a button to clear all tags.

Screen Shot 2024-07-02 at 8 44 01 PM