search

webgpu-native / webgpu-headers

https://webgpu-native.github.io/webgpu-headers/
BSD 3-Clause "New" or "Revised" License
370 stars 43 forks source link

Move __WGPU_EXTEND_ENUM out of the compiler-reserved namespace #353

Closed kainino0x closed 4 days ago

kainino0x commented 4 days ago

I think libraries are supposed to avoid macro names starting with underscores - see https://gcc.gnu.org/onlinedocs/cpp/System-specific-Predefined-Macros.html

We could alternatively come up with some other valid naming convention for internal things like _wgpu_EXTEND_ENUM, WDYT?

kainino0x commented 4 days ago

@rajveermalviya PTAL

rajveermalviya commented 4 days ago

+1 for _wgpu_EXTEND_ENUM (or if possible _WGPU_EXTEND_ENUM), as it's only intended for internal use.

kainino0x commented 4 days ago

Filed #355 since whatever we do we need to do for other internal macros too. Will close this for now and open a new PR that does all of them when we know what we want to do.