Update all sentinel values, reserve 0

kainino0x commented 2 months ago

Can be reviewed as separate commits.

Reorder fields in VertexBufferLayout so the sentinel slot is first (even though this doesn't match the upstream IDL)
Update BindingNotUsed/VertexBufferNotUsed enum values
Removing some Undefineds that don't need to exist
Reserved 0 in all enums without Undefined
Ordered some enums to match the spec

This is a bit different from the thing we previously discussed and agreed on:

I've swapped the values of BindingNotUsed=VertexBufferNotUsed=0 with Undefined=1 so that zero-init will trigger NotUsed. See https://github.com/webgpu-native/webgpu-headers/issues/242#issuecomment-2310857163
I haven't introduced WGPUTextureFormat_ColorTargetNotUsed, opting to continue using WGPUTextureFormat_Undefined for this, because there's basically no chance that WGPUColorTargetState.format becomes optional. (Even if it did become "dynamic state" or something, I think we would use a different sentinel value than undefined in the JS API so that it had to be named explicitly.)

Fixes #234 Fixes #242 EDIT: also fixes #45 (done in Dawn except for the NotUsed changes: https://crbug.com/377820810)

kainino0x commented 2 months ago

@cwfitzgerald @rajveermalviya @Kangz see above about the things I did differently than what we discussed (no need to review fully but feel free). Let me know if you think any of those changes are not good.

cwfitzgerald commented 2 months ago

No notes here

webgpu-native / webgpu-headers

Update all sentinel values, reserve 0 #364