Upgrade to Sylius 1.11 - Githubissues

webgriffe / SyliusAkeneoPlugin

Plugin allowing to import data from Akeneo PIM to your Sylius store.

https://webgriffe.github.io/SyliusAkeneoPlugin/

MIT License

23 stars 2 forks source link

Upgrade to Sylius 1.11 #124

Closed lruozzi9 closed 2 years ago

lruozzi9 commented 2 years ago

Fixes #119

Changes proposed in this pull request:

Drop support for Sylius 1.9 and 1.10
Drop support for Symfony 4.4

@webgriffe/wg-devs what do you think about this PR :shipit:?

LucaGallinari commented 2 years ago

Oh, ok. Found this: https://github.com/Sylius/PluginSkeleton/pull/321/files Didn't see it as it has not been released yet, so the compare didn't find it.

lruozzi9 commented 2 years ago

Oh, ok. Found this: https://github.com/Sylius/PluginSkeleton/pull/321/files Didn't see it as it has not been released yet, so the compare didn't find it.

Yes, that PR has not been already tagged but is needed to make tests green and also to align the test/application with the Sylius 1.11 configurations.

lruozzi9 commented 2 years ago

It still fails on JS behat, I think that is due again to the admin icon image 🤬

lruozzi9 commented 2 years ago

I think this https://github.com/Sylius/Sylius/pull/13753 could resolve the problem definitively, but until is not released I don't know how to fix the build 🤷‍♂️

lruozzi9 commented 2 years ago

Another problem is that composer does not install Sylius 1.11.2 (https://github.com/Sylius/PluginSkeleton/issues/323). The problem is still present in local also with that version.