webgriffe / SyliusItalianInvoiceableOrderPlugin

Sylius plugin which allows Italian merchants to collect invoice data for their orders.
MIT License
4 stars 2 forks source link

The Italian Tax calculation strategy should use the system parameter to check for billing or shipping address #18

Open lruozzi9 opened 1 year ago

lruozzi9 commented 1 year ago

Currently, the ItalianTaxCalculationStrategy uses the billing address to check if the taxes should be skipped or not. With Sylius v1.10 or v1.11 a new config parameter has been added sylius_core.shipping_address_based_taxation. This parameter is used to decide if it should be used the billing or shipping address's country to calculate taxes. I think this parameter (that in v1.12 has been replaced by a Channel property) should be injected in the above service and should be used to decide to check the billing or shipping address. What do you think @webgriffe/wg-devs?

mmenozzi commented 1 year ago

I agree!