Person Validaton Accept VAT value

[fabianobonomini]

Inside the page http://localhost/it/account/address-book/3/edit

as a Person If I try to fill the sylius_address_taxCode with a vat number the validation accepts the data.

I expected that the taxCode was validated from the plugin. Mabye I am missing something?

Best Regards Fabiano

[mmenozzi]

Hi @fabianobonomini, validation depends also on the selected country. Make sure to select Italy as country. Then the tax code should accept only valid Italian tax code (codice fiscale) and not VAT numbers (partita IVA).

[fabianobonomini]

I selected italy. but the bug still there

On Tue, 7 Dec 2021, 08:53 Manuele Menozzi, @.***> wrote:

Hi @fabianobonomini https://github.com/fabianobonomini, validation depends also on the selected country. Make sure to select Italy as country. Then the tax code should accept only valid Italian tax code (codice fiscale) and not VAT numbers (partita IVA).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/webgriffe/SyliusItalianInvoiceableOrderPlugin/issues/9#issuecomment-987659625, or unsubscribe https://github.com/notifications/unsubscribe-auth/AV5P4EC2CKX2SX4PR3A3UDTUPW4PJANCNFSM5JQQBEDQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[mmenozzi]

Sorry @fabianobonomini, you're right and I was wrong. After looking at the code I remembered that we did it intentionally to not introduce too much complexity.

Yes it's true, individual Italian tax code should not accept VAT numbers (but it should for companies) btw we chose to not enforce this validation to keep it simple.

Anyway if you want provide a PR for that we'll be glad to review and merge it.