webgriffe / deployer-magento

Deployer recipe for Magento project
MIT License
11 stars 2 forks source link

Use composer n98-magerun. Fix #1 #2

Closed akira28 closed 3 years ago

mmenozzi commented 6 years ago

Hi @akira28 , thank you for your PR. We don't want to force users to add n98-magerun to project's dependencies. Would you like to change the PR by setting the n98-magerun bin path in a config variable (like magento_root_path) and then using it into proper tasks. I think that the default value of this new variable could be set to n98-magerun inside vendor (vendor/bin/n98-magerun) which falls back to n98-magerun.phar if that file doesn't exists. Do you agree?