search

webguys-de / EasyTemplate

42 stars 13 forks source link

Hotfix code improvements #11

Closed riker09 closed 8 years ago

riker09 commented 8 years ago

This is a first set of improvements to the overall code quality after doing a quick scan with PHP CodeSniffer and the Magento-ECG coding standards as ruleset.

There's more to come, I'm still getting familiar with EasyTemplate which I discovered yesterday. Right now I'm trying to get to know the module.

riker09 commented 8 years ago

I noticed the ID filter, but just like you said, I was trying to establish a pattern here.

If I ever find the time I will open a PR for Magento ECG which will check for things like ID filters and setPageSize(1) and setCurPage(1) and not throw an error/warning. But thats another story.