search

webhintio / hint

💡 A hinting engine for the web
https://webhint.io/
Apache License 2.0
3.62k stars 670 forks source link

The "highest-available-document-mode" doc and report don't match #1226

Closed GuillaumeRossolini closed 6 years ago

GuillaumeRossolini commented 6 years ago

Hi,

We had a meta tag with both ie=edge and chrome=1, so we adjusted to match your documentation: https://webhint.io/docs/user-guide/hints/hint-highest-available-document-mode/

ensure that anyone browsing the site from those browsers will get the best possible user experience that browser can offer.

Now, we use only the HTTP response header: X-UA-Compatible: ie=edge

However, scanning again reports the following error:

Response should not include unneeded 'x-ua-compatible' header.

Should we or should we not include this, as a header or otherwise?

alrra commented 6 years ago

Should we or should we not include this, as a header or otherwise?

@GuillaumeRossolini webhint adapts to your specific needs. So, for example, if you tell it what browsers are relevant to you, and they do not include IE 8/9/10, then the x-ua-compatible rule will adapt and suggest not sending the HTTP header and meta tag as they are not needed for the browsers you specified.

If you are getting the error in the online scanner, it's because we configure it to not include old browsers such as IE 8/9/10.

Note: Everything can be configured if you are using the CLI, but with the online scanner we don't currently allow configurations. If you want to see what configurations the online scanner used for your scan, just click on the View JSON file link.

Hope that clarified things.

GuillaumeRossolini commented 6 years ago

Oh yes, and thank you for being patient.