webhook / webhook-cms

The CMS layer for Webhook.com
http://www.webhook.com
MIT License
178 stars 41 forks source link

Geolocation control with Leaflet. #155

Closed robinvdvleuten closed 10 years ago

robinvdvleuten commented 10 years ago

Hi there,

As mentioned by me in the forums, I created a geolocation field with leafletjs. You can enter both an google url like

https://www.google.nl/maps/place/London,+UK/@51.5286416,-0.1015987,11z/data=!3m1!4b1!4m2!3m1!1s0x47d8a00baf21de75:0x52963a5addd52a99

and a location string like

51.5286416,-0.1015987

Hopefully you'll like the idea :)

gpbmike commented 10 years ago

I've been working on fixing some bugs today but will get this merged in when I have a free moment. From what I've seen after a glance it looks great. Thanks!

snide commented 10 years ago

Just an update but we're still working on some bugs, but this is very much on our todo of stuff to get to this week. Apologies for the wait.

robinvdvleuten commented 10 years ago

No problemo! Do I need to take a look at the current merge conflicts? And any thoughts about making webhook multilanguage? It's a very needed feature of a project I am working on and it would be great to build this site with webhook. Maybe I can help with it through another PR :)

snide commented 10 years ago

We'll take care of any conflicts, no worries.

As to internationalization of the frontend output. It's on our short list of things to do. The CMS side is translated though, you can find the translations here.

https://github.com/webhook/webhook-cms-i18n

robinvdvleuten commented 10 years ago

Yeah I am aware of that, I added dutch translations begin this week ;)

gpbmike commented 10 years ago

We just pushed a bunch of changes today. When you have a chance do you think you can sync your fork so I can merge this in?

robinvdvleuten commented 10 years ago

Done :)

gpbmike commented 10 years ago

This is live with a few tweaks. Thanks again!

snide commented 10 years ago

Here's a link to the generator side if you want to see how the matching scaffolding works.

https://github.com/webhook/webhook-generate/commit/79fc810549f7fa9b29f62a79adcfc04ee4cd69ce

robinvdvleuten commented 10 years ago

Awesome :) keep up the good work guys!