search

webhook / webhook-generate

Grunt Static File Generator
MIT License
21 stars 28 forks source link

String lookup for type in url-function is not case-insensitive #19

Closed lukasluecke closed 10 years ago

lukasluecke commented 10 years ago

It would be easier if the lookup would be case-insensitive. I don't think there are any negative side-effects of changing this.

LtSquigs commented 10 years ago

Seems good, the types are all lower case anyways, so makes sense. Will pull this, and next time we do a push will be available (not sure when we will push next).

lukasluecke commented 10 years ago

Alright, cool. Wasn't sure about the case of types, so my pull-request also has a .toLowerCase() on the type. Might be removed if they are lower case anyways.

On Thu, Oct 16, 2014 at 8:29 PM, Ian Kelly notifications@github.com wrote:

Seems good, the types are all lower case anyways, so makes sense. Will pull this, and next time we do a push will be available (not sure when we will push next).

— Reply to this email directly or view it on GitHub https://github.com/webhook/webhook-generate/issues/19#issuecomment-59407505 .

LtSquigs commented 10 years ago

Just a quick update, this has been pushed live.