search

webignition / robots-txt-file

Models a robots.txt file
MIT License
18 stars 3 forks source link

Not compatible with webignition/disallowed-character-terminated-string 2.0 #15

Closed leofeyer closed 4 years ago

leofeyer commented 4 years ago

This library is not compatible with the new webignition/disallowed-character-terminated-string version 2.0:

Error: Class 'webignition\DisallowedCharacterTerminatedString\DisallowedCharacterTerminatedString' not found in vendor/webignition/robots-txt-file/src/Directive/Value.php:10

Unfortunately, the composer version constraint ">=1.0" allows to install version 2.0. You might want to use a semver version constraint instead: "^1.0"

webignition commented 4 years ago

Wow, nice spot!

I'll sort that out right away.

webignition commented 4 years ago

Assuming PR #19 fixes this, I'll release version 2.1.1 soon.

Given how long it's been since I've worked on this, I'll modernise things a little (remove unsupported PHP versions, use PHP 7.2 features), make things compatible with webignition/disallowed-character-terminated-string 2.0 and roll that up into version 3.

webignition commented 4 years ago

2.1.1 should sort this out:

https://github.com/webignition/robots-txt-file/releases/tag/2.1.1

leofeyer commented 4 years ago

Wow, you are fast. 🚀 Thank you very much!

webignition commented 4 years ago

Had a few minutes to kill waiting for some builds ... !

webignition commented 4 years ago

@leofeyer version 3.0 is now compatible:

https://github.com/webignition/robots-txt-file/releases/tag/3.0