Bug in rgb percentage parsing leads to incorrect conversions

webinista / colortheory

Decided to build a thing on a whim. May not finish.

http://colors.webinista.com/

1 stars 0 forks source link

Bug in rgb percentage parsing leads to incorrect conversions #91

Closed webinista closed 6 years ago

webinista commented 7 years ago

rgb(100%, 100%, 100%) should convert to white / #fff / hsl(0, 0%, 100%). Instead it converts to rgb(100, 100, 100) or #646464 which is gray, not white.

Pretty sure it has to do with a parseInt value that shouldn't parseInt until we know whether a % character is present in the string.

webinista commented 7 years ago

Half fixed it. Need to account for:

0% values
0 values when used with percentages, e.g. rgb(0, 50%, 50%) (should convert to #008080 as rgb(0%, 50%, 50%) does in Chrome). In this case, the color input gets updated. The swatch does not.