search

webinstall / webi-installer-requests

This is just to house issues for requests for new Webi installers.
Mozilla Public License 2.0
8 stars 14 forks source link

Add Brave Browser #61

Open coolaj86 opened 3 years ago

coolaj86 commented 3 years ago

See https://github.com/brave/brave-browser/releases

The generic instructions for how to add a new installer to Webi are here: https://github.com/webinstall/webi-installers/issues/130

On Mac this would be more similar to the iTerm2 installer in that it will go into ~/Applications: https://github.com/webinstall/webi-installers/tree/master/iterm2

adithyasunil26 commented 3 years ago

@coolaj86 This seems like a particularly difficult task because Beave releases their nightly and dev builds also as latest-releases i.e., they don't tag it as a pre-release. This makes it difficult to get the right version. I haven't checked the install procedure yet but getting the version itself seems like a daunting task to me. Please suggest some workarounds if you can think of some.

Visit this issue for details https://github.com/brave/brave-browser/issues/13493.

coolaj86 commented 3 years ago

A workaround would be to copy _common/github and edit it to string match on the title of the release.

an even better solution might be to add an options object (or extend it if one is already there) with a user defined function that receives a github release object and returns a webi release object to be merged with the the current result.