webinstall / webi-installers

Primary and community-submitted packages for webinstall.dev
https://webinstall.dev
Mozilla Public License 2.0
1.94k stars 209 forks source link

`webi_path_add` should output changes to `~/.bashrc` and friends. #727

Closed coolaj86 closed 11 months ago

coolaj86 commented 12 months ago

Re: https://github.com/ajeetdsouza/zoxide/issues/318

I think we had this at one point, but then made opted to make the installer less chatty.

I think it would be good to revisit the output in general - have a nice friendly list like:

Installing xxxx

    Found ~/.bashrc sources ~/.config/envman/PATH.env
    Found ~/.zshrc sources ~/.config/envman/PATH.env
    Updated ~/.config/fish/config.fish
        sources ~/.config/envman/PATH.env
    Updated ~/.config/envman/PATH.env
        set PATH="$HOME/.local/opt/xxxx/bin:$PATH"
    Downloading https://github.com/xxxx/xxxx/releases/0.0.0/xxxx-linux-x64.tar.xz 
        to ~/Downloads/webi/xxxx/0.0.0/xxxx-0.0.0.tar.xz
    Extracting ~/Downloads/webi/xxxx/0.0.0/xxxx-0.0.0.tar.xz
        to ~/.local/opt/xxxx-0.0.0/
    Linking ~/.local/opt/xxxx-0.0.0/
        to ~/.local/opt/xxxx/

    Installed xxxx successfully

To update your PATH immediately
        PATH="$HOME/.local/opt/xxxx/bin:$PATH"

(or open a new terminal, which will have the PATH already updated)

There is an issue of how to handle this for the meta packages, such as vim-essentials, which will need to be solved simultaneously

coolaj86 commented 11 months ago

This was completed as part of #764.