jaridmargolin
commented
10 months ago Alright - I have at least a theory now. Tracing the code above, I am seeing how the release is selected.
Installers.helpercallsgetReleaseswith a handful of release params, includinglimit: 1.getReleasescallsfilterReleaseswhile passing through the limit.- The two releases above,
https://github.com/dandavison/delta/releases/download/0.16.5/delta-0.16.5-arm-unknown-linux-gnueabihf.tar.gzandhttps://github.com/dandavison/delta/releases/download/0.16.5/delta-0.16.5-aarch64-unknown-linux-gnu.tar.gz, make it through the filter logic, however, the results are then sorted and sliced to only return one release.
Where I "believe" the bug is, is the fact that https://github.com/dandavison/delta/releases/download/0.16.5/delta-0.16.5-arm-unknown-linux-gnueabihf.tar.gz makes it through the filter logic. Here is the release query along with the two release objects:
{
pkg: 'delta',
ver: '0.16.5',
os: 'linux',
arch: 'arm64',
libc: 'gnu',
lts: undefined,
channel: undefined,
formats: [ 'exe', 'xz', 'tar', 'zip', 'git' ],
limit: 1
}[
{
name: 'delta-0.16.5-arm-unknown-linux-gnueabihf.tar.gz',
version: '0.16.5',
lts: false,
channel: 'stable',
date: '2023-06-03',
os: 'linux',
arch: 'arm64',
ext: 'tar.gz',
download: 'https://github.com/dandavison/delta/releases/download/0.16.5/delta-0.16.5-arm-unknown-linux-gnueabihf.tar.gz',
libc: 'none'
},
{
name: 'delta-0.16.5-aarch64-unknown-linux-gnu.tar.gz',
version: '0.16.5',
lts: false,
channel: 'stable',
date: '2023-06-03',
os: 'linux',
arch: 'arm64',
ext: 'tar.gz',
download: 'https://github.com/dandavison/delta/releases/download/0.16.5/delta-0.16.5-aarch64-unknown-linux-gnu.tar.gz',
libc: 'gnu'
}
]In this example, the release query states explicitly that it wants libc: "gnu" however the libc: "none" result is not filtered out.
Is the following line correct in checking rel.libc or is it just supposed to check for the closure libc value? https://github.com/webinstall/webi-installers/blob/344c1d6af8ff061b48a2464b2db4e510e45f2943/_webi/transform-releases.js#L192
I see that there were some modifications around this logic a few days ago and curious if this is a newly introduced bug: https://github.com/webinstall/webi-installers/pull/731
coolaj86
What were you trying to install (or what else went wrong)?
I believe that webi is installing the incorrect releases for several packages, including
lsdanddelta, in certain situations.What exactly did you do? / What went wrong? / Which OS did you try on?
Within a devcontainer running on my M1 Mac,
lsdanddeltareport as being successfully installed but then both report errors when being executed:qemu-arm: Could not open '/lib/ld-linux-armhf.so.3': No such file or directory. It should be attempting to useld-linux-aarch64.so.1.Using
delta, I'm tracing things a bit but because some of the logic sits inside of the API, I lose sight of what happens.Linux/5.15.49-linuxkit-pr aarch64/unknown gnuWEBI_PKG_URL='https://github.com/dandavison/delta/releases/download/0.16.5/delta-0.16.5-arm-unknown-linux-gnueabihf.tar.gz'. It's not clear why that would be used rather thanhttps://github.com/dandavison/delta/releases/download/0.16.5/delta-0.16.5-aarch64-unknown-linux-gnu.tar.gz.I'm still poking around but I can't seem to find where the server code for webi lives so I'm not sure how to push this debugging further 🤔
UPDATE: I've found the relevant code paths in
_webi. Time permitting, I'll clone down the source and see if I can get to the bottom of this.UPDATE 2: Continued tracing leading me to a possible error in filterReleases.
What type of computer (i.e. laptop, desktop, Raspberry Pi)?
Laptop or Desktop (amd64 / x86-64)