webinstall / webi-installers

Primary and community-submitted packages for webinstall.dev
https://webinstall.dev
Mozilla Public License 2.0
1.73k stars 184 forks source link

Can't install pwsh #814

Open virzak opened 4 months ago

virzak commented 4 months ago

What were you trying to install (or what else went wrong)?

pwsh

What exactly did you do?

curl -sS https://webi.sh/pwsh@7.4.1 | sh

What went wrong?

You should be able to run the same using docker if you don't have podman

🚀  podman run --rm catthehacker/ubuntu:act-latest sh -c "curl -sS https://webi.sh/pwsh@7.4.1 | sh"

>>> Welcome to Webi! - modern tools, instant installs.  <<<
    We expect your experience to be absolutely perfect!

    Success? Star it!   https://github.com/webinstall/webi-installers
    Problem? Report it: https://github.com/webinstall/webi-installers/issues
                        (your system is GNU/Linux/x86_64 with libc & curl+wget)

Bootstrapping Webi
    Downloading https://webi.sh/packages/webi/webi.sh
        to ~/.local/bin/webi
    Running ~/.local/bin/webi pwsh@7.4.1

Installing pwsh ...
    Found  ~/.local/bin
    Downloading pwsh from
      https://github.com/PowerShell/PowerShell/releases/download/v7.4.1/powershell-7.4.1-linux-x64.tar.gz
    Saved as ~/Downloads/webi/pwsh/7.4.1/powershell-7.4.1-linux-x64.tar.gz
    Extracting ~/Downloads/webi/pwsh/7.4.1/powershell-7.4.1-linux-x64.tar.gz
    Installing to ~/.local/opt/pwsh-v7.4.1/pwsh
    Initializing ~/.config/envman/
    Edit ~/.profile to source ~/.config/envman/load.sh
    Edit ~/.bashrc to source ~/.config/envman/load.sh
Installed 'pwsh' at /root/.local/opt/pwsh
pwsh@7.4.1-install.sh: 470: pwsh: not found

Which OS did you try on?

What type of computer (i.e. laptop, desktop, Raspberry Pi)?

Possible explanation

Since pwsh is not in $PATH yet, it needs to be called fully qualified. https://github.com/webinstall/webi-installers/blob/c431ce0b22dd4a577af1be4f0ebf5c0a22c689ef/pwsh/install.sh#L49

coolaj86 commented 1 month ago

I think that the package format changed between 7.3 and 7.4.

That's the worst, because I really don't want to have conditionals between installer versions.

People just don't treat Releases like an API.