search

webinstall / webi-installers

Primary and community-submitted packages for webinstall.dev
https://webinstall.dev
Mozilla Public License 2.0
1.72k stars 184 forks source link

GitLab releases #824

Open xaocon opened 3 months ago

xaocon commented 3 months ago

I was wanting to add the glab client but it's hosted on gitlab.com and I see there isn't a release lib for it. I see in #4 that it was a consideration at some point but it was closed. Are you interested in this at all? I got started on adding it but ran into a bug with @root/request so before I go too much farther I wanted to make sure that you'd even be up for accepting it.

If you are up for adding GitLab, how do you feel about just using fetch instead of request? In case it matters, the issue with request is that it doesn't append or merge prior info on redirect so relative redirects cause Error: unknown protocol: 'null'.

coolaj86 commented 1 month ago

I'm in a good place for the next 2-3 weeks to focus on Webi, and I'm very open both:

@root/request was a holdover between the time that request became so bloated and dependency-laden that it became a supply-chain vulnerability, and fetch still didn't have full browser+node support.

Do you have time to work on this in the next 2-3 weeks?

coolaj86 commented 4 weeks ago

@xaocon Do you have any time to work on this this week?