webiny / webiny-js

Open-source serverless enterprise CMS. Includes a headless CMS, page builder, form builder, and file manager. Easy to customize and expand. Deploys to AWS.
https://www.webiny.com
Other
7.39k stars 612 forks source link

WebSockets API GW - Remove `aws.apigatewayv2.Deployment` Resource #4053

Closed adrians5j closed 7 months ago

adrians5j commented 7 months ago

Changes

For the new WebSockets API GW (which we'll introduce with 5.40.0), we're removing the aws.apigatewayv2.Deployment cloud infra resource.

This is because it looks like it's not needed. Once I removed the resource, everything still worked. Furthermore, the fact that we've done it like this with our default API GW for a very long time, makes me even more confident that the resource is not required.

How I initially got here? I got here by trying to deploy a brand new project with our CloudFormation template. Upon deploying, AWS complained with the following permissions-related error:

image

Started investigating it and once I learned more, I ended up with this PR.

How Has This Been Tested?

Manually, the Websocket connection was established correctly in Admin app:

image

Documentation

None.

adrians5j commented 7 months ago

/cypress