webiny / webiny-js

Open-source serverless enterprise CMS. Includes a headless CMS, page builder, form builder, and file manager. Easy to customize and expand. Deploys to AWS.
https://www.webiny.com
Other
7.29k stars 601 forks source link

development branch .. build error (ubuntu 18.04) fsevents #569

Closed veerjainATgmail closed 4 years ago

veerjainATgmail commented 4 years ago

Build error with development branch.

This is: Bug

Specifications

Expected Behavior

"optionalDependencies": { "fsevents": "^2.0.7" },

Actual Behavior

yarn fails with error

Steps to Reproduce the Problem

yarn install

veerjainATgmail commented 4 years ago

making "fsevents": "^2.0.7" as optionalDependencies solve this issue.

Pavel910 commented 4 years ago

@veerjainATgmail ah, that's my bad, sorry. Shouldn't be in dependencies since it's an OSX specific package. Glad you figured it out, I'll fix it in the repo 🍻

veerjainATgmail commented 4 years ago

Thanks. :+1:

gabriele-carbonai commented 4 years ago

After you fix it, I still have the same error

[1/4] Resolving packages...
[2/4] Fetching packages...
info fsevents@2.1.3: The platform "linux" is incompatible with this module.
info "fsevents@2.1.3" is an optional dependency and failed compatibility check. Excluding it from installation.
Ashu96 commented 4 years ago

Hey @gomonkey

Can you please tell, which version of webiny and OS are you using?

gabriele-carbonai commented 4 years ago

@Ashu96 I don't know which version is it, I think is the last version of the branch. I just follow the instructions in the documentation here The server is Ubuntu 18.04 (64-bit), same error as reported in this issue.

Pavel910 commented 4 years ago

@gomonkey that's not an error, just an info. For example, for OSX that dependency works fine so it will be installed. For Windows, it will simply skip that dependency but print that info to tell you that it's Excluding it from installation..