Clean up even on error - Githubissues

webis-de / scriptor

Plug-and-play reproducible web analysis.

MIT License

5 stars 2 forks source link

Clean up even on error #24

Open johanneskiesel opened 2 years ago

johanneskiesel commented 2 years ago

Though this is now what I originally intended, someone is now running the entrypoint several times in a row. To support this, it would be necessary to clean up a bit more after an error occurs.

The critical spot seems to be here: https://github.com/webis-de/scriptor/blob/4a9329fd916bf8efc60c81da06aa91fb3a8cb838/lib/scripts.js#L76

johanneskiesel commented 2 years ago

This also needs more killing (xvfb): https://github.com/webis-de/scriptor/blob/4a9329fd916bf8efc60c81da06aa91fb3a8cb838/lib/scripts.js#L352