webis-de / small-text

Active Learning for Text Classification in Python

https://small-text.readthedocs.io/

MIT License

547 stars 60 forks source link

Add batch_size to lightweight_coreset function #42

Closed RaghavPrabhakar66 closed 1 year ago

RaghavPrabhakar66 commented 1 year ago

Pull Request

[x] In confirm that I have read the CONTRIBUTING.md document.
[x] I confirm that this contribution is made under an MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.
[x] I confirm that I did not use any AI-based coding assistance (such as, but not limited to, GitHub Copilot).

Description

Fixes #23.

chschroeder commented 1 year ago

Hi @RaghavPrabhakar66! Thanks for your contribution.

Except for one small detail, this looks already good :). Well done. I left a code review comment at the relevant location. Do you agree with the proposed change?

RaghavPrabhakar66 commented 1 year ago

@chschroeder Thank you for your feedback. I have made the requested change.