CHECKPATCH_COMMAND not working?

MatiasElo commented 3 years ago

Hi,

I'm having trouble when trying to use a custom checkpatch script with the CHECKPATCH_COMMAND env variable. Setting the variable doesn't seem to have any effect and the standard checkpatch.pl script is always used.

Below is a snippet from our config. ./scripts/checkpatch.pl is a modified checkpatch script in our repo.

jobs:
  Checkpatch:
    runs-on: ubuntu-18.04
    steps:
    - uses: actions/checkout@v2
      with:
        fetch-depth: 0

    - name: Install dependencies
      run: sudo apt install codespell

    - name: Check pull request
      if: github.event_name == 'pull_request'
      env:
        CHECKPATCH_COMMAND: ./scripts/checkpatch.pl
      uses: webispy/checkpatch-action@v6

webispy commented 3 years ago

Sorry. I forgot the v7 release for the latest code. I just released it, so try again with webispy/checkpatch-action@v7 orwebispy/checkpatch@master version.

MatiasElo commented 3 years ago

Well that was fast :) Thanks, I'll test it right away.

MatiasElo commented 3 years ago

v7 is now working as expected. Many thanks!

One suggestion would be to add codespell package to the Dockefile to enable better spell checking.

webispy commented 3 years ago

Glad it works. I will add the codespell package in the next version. Thanks for the suggestion!

webispy / checkpatch-action

CHECKPATCH_COMMAND not working? #9