search

webjars / jquery

22 stars 26 forks source link

Include slim version #72

Closed benjavalero closed 5 years ago

benjavalero commented 5 years ago

Should the slim version of jQuery be included in this package, or in a dedicated one? I don't know well if there is a real benefit in using it, but it is recommended for instance by Bootstrap.

jamesward commented 5 years ago

I think it'd make sense to put it in this one. Will work on that soon, or will take a pull request. :)

mgimpel commented 5 years ago

I adding this to the POM file would seem to do the job

                    <execution>
                        <id>download-slim-js</id>
                        <phase>process-resources</phase>
                        <goals><goal>download-single</goal></goals>
                        <configuration>
                            <url>${downloadUrl}</url>
                            <fromFile>jquery.slim.js</fromFile>
                            <toFile>${destinationDir}/jquery.slim.js</toFile>
                        </configuration>
                    </execution>
                    <execution>
                        <id>download-slim-min-js</id>
                        <phase>process-resources</phase>
                        <goals><goal>download-single</goal></goals>
                        <configuration>
                            <url>${downloadUrl}</url>
                            <fromFile>jquery.slim.min.js</fromFile>
                            <toFile>${destinationDir}/jquery.slim.min.js</toFile>
                        </configuration>
                    </execution>
                    <execution>
                        <id>download-slim-source-map</id>
                        <phase>process-resources</phase>
                        <goals><goal>download-single</goal></goals>
                        <configuration>
                            <url>${downloadUrl}</url>
                            <fromFile>jquery.slim.min.map</fromFile>
                            <toFile>${destinationDir}/jquery.slim.min.map</toFile>
                        </configuration>
                    </execution>

Would you prefer a pull request?

jamesward commented 5 years ago

Thanks! This is being released as 3.3.1-2