search

webjars / swagger-ui

50 stars 14 forks source link

Published 5.15.2 seems corrupt #212

Open Peksa opened 5 months ago

Peksa commented 5 months ago

Compared to 5.15.1, paths have changed, and it contains lots of unrelated files:

https://www.webjars.org/listfiles/org.webjars/swagger-ui/5.15.1 https://www.webjars.org/listfiles/org.webjars/swagger-ui/5.15.2

jamesward commented 5 months ago

Looks like something went wrong with the new way to deploy these: https://github.com/webjars/webjars/issues/2065

I'll investigate.

jamesward commented 5 months ago

I have a fix that should be deployed soon: https://github.com/webjars/webjars/commit/3f60ab9b334fcba080e39cdae8462073be8387e6

Once deployed I'll try to recreate the broken 5.15.2 release (but it will have to be 5.15.2-1 since Maven Central artifacts are immutable.

jamesward commented 5 months ago

Ok, 5.15.2-1 has been released and looks better. It will take about an hour to get to Maven Central. Let me know how it goes and sorry about the issue. My tests were insufficient and that has been addressed.

hboutemy commented 5 months ago

no Git commit nor Git tag here https://github.com/webjars/swagger-ui/tags

something remains weird

jamesward commented 5 months ago

The new user deployable WebJars no longer use git repos. So that part is expected.

hboutemy commented 5 months ago

ok, I see: looks reasonable given how it's largely a copy/paste

question: is there a way to rebuild and check reproducible builds with the new approach? I'm trying to continue https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/webjars/swagger-ui/README.md

jamesward commented 5 months ago

Since there isn't a Maven build for the new user deployable Classic WebJars, I don't know how we'd check for build reproducibility.

hboutemy commented 5 months ago

no problem if the build is done with another tool: Reproducible Central is more about the distribution to Maven Central repository than the build tool used to create the jars

jamesward commented 5 months ago

I'm not totally sure what I need to do. Any pointers?

hboutemy commented 5 months ago

please just tell me how I can rebuild locally swagger-ui 5.17.0: once I can do it by hand, I'll see how to integrate into the Reproducible Central automation (which won't be the same Git repository, for example, and not the same command line as older releases)

you can see a working rebuild by cloning Reproducible Central repository and running ./rebuild.sh content/org/webjars/swagger-ui/swagger-ui-5.15.1.buildspec for example (requires Linux or Mac)

vkolomeyko commented 5 months ago

Cross-posting here: https://github.com/swagger-api/swagger-ui/issues/9869 This is about OSGi manifest missing from version 5.15.2.

jamesward commented 5 months ago

@hboutemy Like with NPM WebJars, there isn't really a build for the new Classic WebJar deployment. webjars.org creates the package (jars, pom, etc) and uploads it to Maven Central. I could add an endpoint on webjars.org that'd create the package and download it, but I don't know if that helps at all.

@vkolomeyko Can you open a new issue for that: https://github.com/webjars/webjars/issues/new/choose

vkolomeyko commented 5 months ago

@jamesward - I have raised: https://github.com/webjars/webjars/issues/2070