search

webjars / webjars-play

MIT License
80 stars 34 forks source link

New release to support Play 2.7 #83

Closed ignasi35 closed 5 years ago

ignasi35 commented 5 years ago

Hi @jamesward , it'd be great to have a new release compatible with Play 2.7. We've already release 2.7.0-RC3 and nearing GA (hopefully before end of year).

/cc @marcospereira

jamesward commented 5 years ago

I've released 2.7.0-RC3 - let me know if you have any issues.

marcospereira commented 5 years ago

Thanks a lot for being so responsive, @jamesward!

ignasi35 commented 5 years ago

Pff, you're so fast you make my slack discussions obsolete before anyone can respond to them.

Thanks @jamesward

francisdb commented 5 years ago

just adding a relevant stack trace so people find this issue:

play.api.UnexpectedException: Unexpected exception[AbstractMethodError: Method org/webjars/play/RequireJS.play$api$mvc$Results$_setter_$PreconditionRequired_$eq(Lplay/api/mvc/Results$Status;)V is abstract]
    at play.core.server.DevServerStart$$anon$1.reload(DevServerStart.scala:200)
    at play.core.server.DevServerStart$$anon$1.get(DevServerStart.scala:127)
    at play.core.server.AkkaHttpServer.handleRequest(AkkaHttpServer.scala:253)
    at play.core.server.AkkaHttpServer.$anonfun$createServerBinding$1(AkkaHttpServer.scala:149)
    at akka.stream.impl.fusing.MapAsync$$anon$30.onPush(Ops.scala:1207)
Caused by: java.lang.AbstractMethodError: Method org/webjars/play/RequireJS.play$api$mvc$Results$_setter_$PreconditionRequired_$eq(Lplay/api/mvc/Results$Status;)V is abstract
    at org.webjars.play.RequireJS.play$api$mvc$Results$_setter_$PreconditionRequired_$eq(RequireJS.scala)
    at play.api.mvc.Results.$init$(Results.scala:669)
    at org.webjars.play.RequireJS.<init>(RequireJS.scala:9)
    at modules.FixedWebjarComponents.requireJs(TvApplicationLoader.scala:37)
    at modules.FixedWebjarComponents.requireJs$(TvApplicationLoader.scala:37)
marcospereira commented 5 years ago

@francisdb is that happening with the the combination of:

  1. Play 2.7.0
  2. webjars-play 2.7.0

?

francisdb commented 5 years ago

no, it's happening with the previous webjars play (when you forget to upgrade the webjars-play dependency)