search

webjars / webjars-play

MIT License
80 stars 34 forks source link

Use AdoptOpenJDK 8 & 11 in Travis build #91

Closed marcospereira closed 4 years ago

marcospereira commented 4 years ago

@jamesward not sure how the branch policy works here, but you may want to backport this to the current stable branch if it exists (I mean, the branch supporting Play 2.7). As usual, let me know if I can help somehow.

jamesward commented 4 years ago

Thanks! Seems like we have some work to do to support JDK 11.

dwijnand commented 4 years ago

Opened https://github.com/webjars/webjars-locator/issues/2, before seeing the https://github.com/webjars/webjars-locator-core/pull/34 backlink to here.

jamesward commented 4 years ago

webjars-play 2.8.0-RC1 has been released. Let me know if you have any issues. Thanks!

jamesward commented 4 years ago

Oh, looks like it is still failing on JDK 11 :( I need to investigate further.

jamesward commented 4 years ago

This seems to be because we ignore the parent classloaders in webjars-locator-core. I'm not sure why I did that. Gonna make a change down there and roll it up.

jamesward commented 4 years ago

Ok, 2.8.0-RC1-1 has been released which should work on Java 11.