webkom / lego

Backend for abakus.no
https://lego.abakus.no
MIT License
55 stars 20 forks source link

Create a membership history when updating a membership #3301

Open ivarnakken opened 1 year ago

ivarnakken commented 1 year ago

Frontend change: https://github.com/webkom/lego-webapp/pull/3805

Tested manually that the creation of membership history works, but I'll write up a quick test for it soon.

Related to ABA-400

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 58.33% and project coverage change: -0.02 :warning:

Comparison is base (45c2a5b) 88.32% compared to head (2c891a5) 88.30%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3301 +/- ## ========================================== - Coverage 88.32% 88.30% -0.02% ========================================== Files 661 661 Lines 20882 20893 +11 ========================================== + Hits 18444 18450 +6 - Misses 2438 2443 +5 ``` | [Impacted Files](https://codecov.io/gh/webkom/lego/pull/3301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webkom) | Coverage Δ | | |---|---|---| | [lego/apps/users/views/memberships.py](https://codecov.io/gh/webkom/lego/pull/3301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webkom#diff-bGVnby9hcHBzL3VzZXJzL3ZpZXdzL21lbWJlcnNoaXBzLnB5) | `82.85% <58.33%> (-12.98%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webkom). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webkom)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.