Open Arashfa0301 opened 1 year ago
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
1362f10
) 88.30% compared to head (7a487fa
) 88.26%. Report is 156 commits behind head on master.:exclamation: Current head 7a487fa differs from pull request most recent head d531414. Consider uploading reports for the commit d531414 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Just reminder to my self: Remember to type the changes
After a meeting between all the committees responsible for events a conclusion to alter the rules for prikker was reached. This has to be implemented. The new rules are: * If you have one or more prikk you have to wait 5 hours after the ordinary registration start for an event before you can register. * The duration of a prikk is 10 days or 6 events where you have permission to register (påmeldingsrett). Each new prikk leads to an addition of the duration (i.e. 10 more days/ 6 events with a prikk) i.e. the number of prikks you have does not really matter anymore, it only matters how long you have them. pr: [https://github.com/webkom/lego/pull/3349](https://github.com/webkom/lego/pull/3349)
Implement new rules and consequences for penalties. The changes are as following:
The biggest change is the addition of PenaltyGroup for the purpose of separating penalty consequence calculation logic and the the information used in front-end.
I have deleted some tests that believe are not needed for our new implementation and i have also made changes to events app that i deemed necessary. I would appreciate reviewing specially these changes as it might be possible that i made some mistakes.
Resolves ABA-92