webkom / lego

Backend for abakus.no
https://lego.abakus.no
MIT License
55 stars 20 forks source link

Add slugs to joblistings and articles #3370

Closed ollfkaih closed 1 year ago

ollfkaih commented 1 year ago

Resolves ABA-211

linear[bot] commented 1 year ago
ABA-211 Add slug fields to backend

events, joblistings and interestgroups We need to autogenerate, enforce unique and make sure that we are backwards compatible. So if we want to manually edit a slug, we would need to support all previous slugs as well.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 76.66% and project coverage change: -0.02 :warning:

Comparison is base (5d19b4d) 88.30% compared to head (2a49012) 88.29%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3370 +/- ## ========================================== - Coverage 88.30% 88.29% -0.02% ========================================== Files 662 662 Lines 20976 21005 +29 ========================================== + Hits 18523 18546 +23 - Misses 2453 2459 +6 ``` | [Impacted Files](https://app.codecov.io/gh/webkom/lego/pull/3370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webkom) | Coverage Δ | | |---|---|---| | [lego/apps/articles/serializers.py](https://app.codecov.io/gh/webkom/lego/pull/3370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webkom#diff-bGVnby9hcHBzL2FydGljbGVzL3NlcmlhbGl6ZXJzLnB5) | `100.00% <ø> (ø)` | | | [lego/apps/events/serializers/events.py](https://app.codecov.io/gh/webkom/lego/pull/3370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webkom#diff-bGVnby9hcHBzL2V2ZW50cy9zZXJpYWxpemVycy9ldmVudHMucHk=) | `96.83% <ø> (ø)` | | | [lego/apps/events/views.py](https://app.codecov.io/gh/webkom/lego/pull/3370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webkom#diff-bGVnby9hcHBzL2V2ZW50cy92aWV3cy5weQ==) | `84.15% <0.00%> (ø)` | | | [lego/apps/joblistings/serializer.py](https://app.codecov.io/gh/webkom/lego/pull/3370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webkom#diff-bGVnby9hcHBzL2pvYmxpc3RpbmdzL3NlcmlhbGl6ZXIucHk=) | `100.00% <ø> (ø)` | | | [lego/apps/joblistings/views.py](https://app.codecov.io/gh/webkom/lego/pull/3370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webkom#diff-bGVnby9hcHBzL2pvYmxpc3RpbmdzL3ZpZXdzLnB5) | `88.23% <71.42%> (-11.77%)` | :arrow_down: | | [lego/apps/articles/views.py](https://app.codecov.io/gh/webkom/lego/pull/3370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webkom#diff-bGVnby9hcHBzL2FydGljbGVzL3ZpZXdzLnB5) | `94.59% <86.66%> (-5.41%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

ollfkaih commented 1 year ago

Not sure if I get your fix tests commits.

They changed the code so the tests would pass (mostly returning specified error codes), but yes, kinda bad commit messages